Fix resource.rc encoding #1896
Merged
Fix resource.rc encoding #1896
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lokitoth
force-pushed
the
dev/fix_resource_rc
branch
2 times, most recently
from
31294d1
to
0732884
Compare
lokitoth
force-pushed
the
dev/fix_resource_rc
branch
from
0732884
to
7b8652f
Compare
|
Thanks for fixing this Jacob! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some time ago we changed the *.rc files encoding to request git to set it to the proper encoding: UTF-16LE. Unfortunately, the autocrlf breaks this conversion, which breaks the version stamping. The fix is to admit that git does not deal with UTF-16 in a functional way, and just treat resource files as binary.